Fix race in GN pod for out-of-order RemoteEndpoint events #2532
+38
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is a gateway migration in a remote cluster or if there is any stale endpoint on the Broker associated with the remoteCluster, the events might come in out of order which can create issues for datapath connectivity. This PR includes the necessary checks in Globalnet pod to ignore any stale events. Related to: submariner-io#2399 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
|
🤖 Created branch: z_pr2532/sridhargaddam/fix-ooo-events-gn |
sridhargaddam
added
the
backport
aswinsuryan
approved these changes
Jun 5, 2023
skitt
approved these changes
Jun 5, 2023
tpantelis
approved these changes
Jun 5, 2023
|
🤖 Closed branches: [z_pr2532/sridhargaddam/fix-ooo-events-gn] |
sridhargaddam
added a commit
to sridhargaddam/submariner-website
that referenced
this pull request
Jul 5, 2023
Includes the release notes for the following fixes. * Submariner now uses case-insensitive comparison while parsing CNI names. * subctl gather now collects Metrics proxy pod logs in a Globalnet deployment. * Submariner Gateway pod now skips invoking cableEngine cleanup during termination, as this is handled by the Route agent during gateway migration. * Fixed issue which caused the IPsec pluto process to crash when the remote endpoint was unstable. * Submariner now handles out-of-order remote endpoint notifications properly in Globalnet component. Related to: submariner-io/submariner#2486 Related to: submariner-io/subctl#770 Related to: submariner-io/submariner#2499 Related to: submariner-io/submariner#2517 Related to: submariner-io/submariner#2532 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
sridhargaddam
added a commit
to sridhargaddam/submariner-website
that referenced
this pull request
Jul 6, 2023
Includes the release notes for the following fixes. * Submariner now uses case-insensitive comparison while parsing CNI names. * subctl gather now collects Metrics proxy pod logs in a Globalnet deployment. * Submariner Gateway pod now skips invoking cableEngine cleanup during termination, as this is handled by the Route agent during gateway migration. * Fixed issue which caused the IPsec pluto process to crash when the remote endpoint was unstable. * Submariner now handles out-of-order remote endpoint notifications properly in Globalnet component. Related to: submariner-io/submariner#2486 Related to: submariner-io/subctl#770 Related to: submariner-io/submariner#2499 Related to: submariner-io/submariner#2517 Related to: submariner-io/submariner#2532 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
skitt
pushed a commit
to skitt/submariner-website
that referenced
this pull request
Jul 10, 2023
Includes the release notes for the following fixes. * Submariner now uses case-insensitive comparison while parsing CNI names. * subctl gather now collects Metrics proxy pod logs in a Globalnet deployment. * Submariner Gateway pod now skips invoking cableEngine cleanup during termination, as this is handled by the Route agent during gateway migration. * Fixed issue which caused the IPsec pluto process to crash when the remote endpoint was unstable. * Submariner now handles out-of-order remote endpoint notifications properly in Globalnet component. Related to: submariner-io/submariner#2486 Related to: submariner-io/subctl#770 Related to: submariner-io/submariner#2499 Related to: submariner-io/submariner#2517 Related to: submariner-io/submariner#2532 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
skitt
pushed a commit
to skitt/submariner-website
that referenced
this pull request
Jul 10, 2023
Includes the release notes for the following fixes. * Submariner now uses case-insensitive comparison while parsing CNI names. * subctl gather now collects Metrics proxy pod logs in a Globalnet deployment. * Submariner Gateway pod now skips invoking cableEngine cleanup during termination, as this is handled by the Route agent during gateway migration. * Fixed issue which caused the IPsec pluto process to crash when the remote endpoint was unstable. * Submariner now handles out-of-order remote endpoint notifications properly in Globalnet component. Related to: submariner-io/submariner#2486 Related to: submariner-io/subctl#770 Related to: submariner-io/submariner#2499 Related to: submariner-io/submariner#2517 Related to: submariner-io/submariner#2532 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
skitt
pushed a commit
to submariner-io/submariner-website
that referenced
this pull request
Jul 10, 2023
Includes the release notes for the following fixes. * Submariner now uses case-insensitive comparison while parsing CNI names. * subctl gather now collects Metrics proxy pod logs in a Globalnet deployment. * Submariner Gateway pod now skips invoking cableEngine cleanup during termination, as this is handled by the Route agent during gateway migration. * Fixed issue which caused the IPsec pluto process to crash when the remote endpoint was unstable. * Submariner now handles out-of-order remote endpoint notifications properly in Globalnet component. Related to: submariner-io/submariner#2486 Related to: submariner-io/subctl#770 Related to: submariner-io/submariner#2499 Related to: submariner-io/submariner#2517 Related to: submariner-io/submariner#2532 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
dfarrell07
pushed a commit
to dfarrell07/submariner-website
that referenced
this pull request
Oct 18, 2023
Includes the release notes for the following fixes. * Submariner now uses case-insensitive comparison while parsing CNI names. * subctl gather now collects Metrics proxy pod logs in a Globalnet deployment. * Submariner Gateway pod now skips invoking cableEngine cleanup during termination, as this is handled by the Route agent during gateway migration. * Fixed issue which caused the IPsec pluto process to crash when the remote endpoint was unstable. * Submariner now handles out-of-order remote endpoint notifications properly in Globalnet component. Related to: submariner-io/submariner#2486 Related to: submariner-io/subctl#770 Related to: submariner-io/submariner#2499 Related to: submariner-io/submariner#2517 Related to: submariner-io/submariner#2532 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
dfarrell07
pushed a commit
to dfarrell07/submariner-website
that referenced
this pull request
Oct 18, 2023
Includes the release notes for the following fixes. * Submariner now uses case-insensitive comparison while parsing CNI names. * subctl gather now collects Metrics proxy pod logs in a Globalnet deployment. * Submariner Gateway pod now skips invoking cableEngine cleanup during termination, as this is handled by the Route agent during gateway migration. * Fixed issue which caused the IPsec pluto process to crash when the remote endpoint was unstable. * Submariner now handles out-of-order remote endpoint notifications properly in Globalnet component. Related to: submariner-io/submariner#2486 Related to: submariner-io/subctl#770 Related to: submariner-io/submariner#2499 Related to: submariner-io/submariner#2517 Related to: submariner-io/submariner#2532 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
dfarrell07
pushed a commit
to dfarrell07/submariner-website
that referenced
this pull request
Oct 19, 2023
Includes the release notes for the following fixes. * Submariner now uses case-insensitive comparison while parsing CNI names. * subctl gather now collects Metrics proxy pod logs in a Globalnet deployment. * Submariner Gateway pod now skips invoking cableEngine cleanup during termination, as this is handled by the Route agent during gateway migration. * Fixed issue which caused the IPsec pluto process to crash when the remote endpoint was unstable. * Submariner now handles out-of-order remote endpoint notifications properly in Globalnet component. Related to: submariner-io/submariner#2486 Related to: submariner-io/subctl#770 Related to: submariner-io/submariner#2499 Related to: submariner-io/submariner#2517 Related to: submariner-io/submariner#2532 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
tpantelis
pushed a commit
to submariner-io/submariner-website
that referenced
this pull request
Oct 22, 2023
Includes the release notes for the following fixes. * Submariner now uses case-insensitive comparison while parsing CNI names. * subctl gather now collects Metrics proxy pod logs in a Globalnet deployment. * Submariner Gateway pod now skips invoking cableEngine cleanup during termination, as this is handled by the Route agent during gateway migration. * Fixed issue which caused the IPsec pluto process to crash when the remote endpoint was unstable. * Submariner now handles out-of-order remote endpoint notifications properly in Globalnet component. Related to: submariner-io/submariner#2486 Related to: submariner-io/subctl#770 Related to: submariner-io/submariner#2499 Related to: submariner-io/submariner#2517 Related to: submariner-io/submariner#2532 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
tpantelis
pushed a commit
to tpantelis/submariner-website
that referenced
this pull request
Nov 7, 2023
Includes the release notes for the following fixes. * Submariner now uses case-insensitive comparison while parsing CNI names. * subctl gather now collects Metrics proxy pod logs in a Globalnet deployment. * Submariner Gateway pod now skips invoking cableEngine cleanup during termination, as this is handled by the Route agent during gateway migration. * Fixed issue which caused the IPsec pluto process to crash when the remote endpoint was unstable. * Submariner now handles out-of-order remote endpoint notifications properly in Globalnet component. Related to: submariner-io/submariner#2486 Related to: submariner-io/subctl#770 Related to: submariner-io/submariner#2499 Related to: submariner-io/submariner#2517 Related to: submariner-io/submariner#2532 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is a gateway migration in a remote cluster or if there is any stale endpoint on the Broker associated with the remoteCluster, the events might come in out of order which can create issues for datapath connectivity. This PR includes the necessary checks in Globalnet pod to ignore any stale events.
Related to: #2399
Signed-off-by: Sridhar Gaddam sgaddam@redhat.com